[PATCH] Fix bug #11177 - no talloc stackframe at ../source3/libsmb/clifsinfo.c:444, leaking memory

[Volker Lendecke]

On Tue, Apr 14, 2015 at 05:28:53PM +1200, Andrew Bartlett wrote:
> Do we still get that when each function has a talloc_stackframe(), and
> talloc_tos() is never called?  That is all I'm really looking for.

Can you explain what you have in mind in a bit more detail?

talloc_tos() as such is a very cheap call, it just reads a value from an
array. talloc_stackframe() has to call talloc_new, which is significantly
more expensive. It will trigger talloc_free calls later on. Mind you, in
CPU statistics talloc_free() is right now very high, and I want to avoid
replacing cheap talloc_tos() calls with more expensive talloc_stackframe
calls.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de