[PATCH] Fix bug #11177 - no talloc stackframe at ../source3/libsmb/clifsinfo.c:444, leaking memory

[Andrew Bartlett]

On Thu, 2015-03-26 at 18:43 +0100, Michael Adam wrote:
> The patch looks good, pushing.
> 
> One comment:
> 
> Somehow it feels awkward that all those SMBC_foo_ctx
> functions should have to create a talloc stackframe
> even if they don't need one themselves, just so that
> functions later in the call chain can be lazy.
> Can't this be done in a central place?
> (Or have I lost it completely?)

This is perhaps the biggest (rational) reason why I dislike
talloc_tos(). 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150414/f49b369c/attachment.pgp>