[PATCHES] let the raw.notify test use torture_asserts.
abartlet at samba.org
Mon Apr 13 18:47:27 MDT 2015
On Fri, 2015-03-27 at 17:50 +0100, Guenther Deschner wrote:
> Currently reviewing this.
> On 27/03/15 10:49, Michael Adam wrote:
> > Hi,
> > the samba3.raw.notify test fails for me sometimes. But since the
> > code is not using torture_assert/torture_result macros (using
> > printfs and return instead), one can not really tell what is going
> > on.
> > Attached find a patchset that cleans up the notify test to use
> > torture_assert macros consistently. (the first two patches also add
> > some macros that I found useful).
> > Review/push appreciated.
> > Michael
This test fails almost all the time in the Catalyst Cloud, and so it
would be really good to get the failures correctly reported with
subunit, so we can make a smaller flapping entry (and even better if it
could be fixed - I can provide access to a failing image).
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part
More information about the samba-technical