waf and pkg-config

[Alexander Bokovoy]

On Wed, Apr 8, 2015 at 9:13 AM, Alexander Bokovoy <ab at samba.org> wrote:
> On Wed, Apr 8, 2015 at 12:23 AM, Jelmer Vernooij <jelmer at samba.org> wrote:
>> On Tue, Apr 07, 2015 at 08:28:58PM +0200, Andreas Schneider wrote:
>>> On Tuesday 07 April 2015 20:11:32 Jelmer Vernooij wrote:
>>> > On Tue, Apr 07, 2015 at 05:23:19PM +0200, Andreas Schneider wrote:
>>> > > trying to fix systemd detection, I found out that waf and pkg-config is
>>> > > simply not working.
>>> > >
>>> > > I do
>>> > >
>>> > >     conf.check_cfg(package='libsystemd-daemon', args='--cflags --libs',
>>> > >
>>> > >                    msg='Checking for libsystemd-daemon')
>>> > >
>>> > > and in the end I can't simply use libsystem-daemon as a dependency. So *I*
>>> > > have to implement library detection again with CHECK_LIB and check all
>>> > > names pkg-config might return on different Linux version?
>>> >
>>> > See source4/lib/tls/wscript:24 for an example.
>>>
>>> I've looked into this and didn't get it working. The patch I've sent fixes the
>>> issue. I do not see another way ...
>>>
>>> If you have a better one, please share or push mine.
>> What does bin/config.log say about libsystemd-daemon?
>>
>> Is there a specific reason you're using uselib_store with a different
>> name than the library name?
> Yes, the library got included into libsystemd after v216. There is a
> compatibility layer in pkg-config that responds to old name.
> Old name is what is used up to and including Fedora 21, new version is
> in Fedora 22, unreleased.

Final fix, together with v4.2 backport.




-- 
/ Alexander Bokovoy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-waf-Fix-systemd-detection.patch
Type: text/x-patch
Size: 6994 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150408/20ac440a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4.2-0001-build-Move-systemd-checks-to-lib-util.patch
Type: text/x-patch
Size: 4484 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150408/20ac440a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4.2-0002-waf-Fix-systemd-detection.patch
Type: text/x-patch
Size: 4777 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150408/20ac440a/attachment-0002.bin>