[PATCH] ctdb: Coverity fix for CID 1291643

Michael Adam obnox at samba.org
Wed Apr 1 03:04:59 MDT 2015


Pushed to autobuild in the amended form, and pushed
David's add-on patch, after checking back with
both Rajesh and David on IRC.

Thanks all for your patience! :)

Michael

On 2015-04-01 at 01:45 -0400, Rajesh Joseph wrote:
> 
> 
> ----- Original Message -----
> > From: "Michael Adam" <obnox at samba.org>
> > To: "David Disseldorp" <ddiss at suse.de>
> > Cc: "Samba Technical" <samba-technical at lists.samba.org>, "Rajesh Joseph" <rjoseph at redhat.com>
> > Sent: Tuesday, March 31, 2015 10:04:22 PM
> > Subject: Re: [PATCH] ctdb: Coverity fix for CID 1291643
> > 
> > Quite frankly I would like the first hunk
> > squashed with Rajesh's patch.
> > 
> > This is also what your commit msg claims: to add the
> > check for talloc_asprintf failure. :)
> > 
> > The last hunk: reviewed-by me
> 
> Thanks Dave and Michael for such a thorough review. Thanks
> Dave for sending the patch to fix the 80 char limit and
> another memory leak issue.
> 
> Actually I had fixed some more memory leaks as part of this patch,
> but after Michael's comment I removed them. I will be sending
> separate patches to address them.
> 
> Thanks & Regards,
> Rajesh
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150401/8306dccf/attachment.pgp>


More information about the samba-technical mailing list