[PATCH] Create talloc-less functions for formating GUID

Christian Ambach ambi at samba.org
Tue Sep 30 15:52:47 MDT 2014

Am 30.09.14 08:59, schrieb Matthieu Patou:
> On 09/29/2014 11:34 PM, Volker Lendecke wrote:
>> On Mon, Sep 29, 2014 at 05:57:11PM -0700, Matthieu Patou wrote:
>>> I would like to discuss this patch, if I understand well it's in the
>>> same idea as what Volker did for file_id to strings function.
>>> Is ok or do we need something else ?
>> Well, I like it, except for some different formatting. See
>> attached. Also, we should use it right away in GUID_string.
>> Also see attached. If you want to push it, Reviewed-by: Me.
>> Volker
> I like your idea too.
> I'll wait for a few hours to get more feedback and if nothing bad push
> both patches.
Maybe you can fix the grammatical errors in the comment before pushing?

My proposal:
+ * Does the same without allocating memory, using the structure buffer.
+ * Useful for debug messages, so that you do not have to talloc_free 
the result
+ */


More information about the samba-technical mailing list