[PATCH] resolver: do not use stack allocated variables

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Sep 30 00:37:49 MDT 2014


On Mon, Sep 29, 2014 at 05:52:47PM -0700, Matthieu Patou wrote:
> Hello,
> 
> Please find the attached patch.
> 
> Can someone review it ?

It certainly is ok and matches our "normal" calling
convention. However, in this particular case I see

c->status = nbt_name_dup(state, name, &state->name);

in resolve_name_all_send(). What triggered this patch? Did
it crash somewhere?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list