[PATCH] SMB2 AAPL create context (was: Mac OS Mavericks über slow)

[Ralph Böhme]

On Thu, Sep 11, 2014 at 04:16:04PM +0200, Volker Lendecke wrote:
> On Thu, Sep 11, 2014 at 03:22:44PM +0200, Ralph Böhme wrote:
> > >From 7a023ac43b052bf8796b5648701a80874bcee2e4 Mon Sep 17 00:00:00 2001
> > From: Ralph Boehme <rb at sernet.de>
> > Date: Fri, 22 Aug 2014 03:45:15 +0200
> > Subject: [PATCH 1/6] s3:smbd: make get_file_handle_for_metadata() public
> > 
> > In preperation of SMB2 AAPL create context: will be used when
> > enumerating directories in order to internally retrieve stream
> > information of filesystem objects.
> 
> Looks extremely interesting.
> 
> One quick comment: lp_parm_bool can be expensive. I'd rather
> not have this in a hot code path. Either copy that parameter
> to connection_struct (or whatever ;-)) at tcon time or make
> it a real parameter.

Ok. I've moved this to vfs_fruit:connect().

That means that the AAPL extensions won't ever get used without
vfs_fruit, which makes sense because

* it requires a robust streams backend and only vfs_fruit supports a
  resource fork stream of arbitrary size

* functionality for modifying UNIX mode via get/set_nt_acl is
  implemented as part of the vfs_fruit module. This functionality
  could be moved to a module of its own, but I preferred to put this
  into vfs_fruit.

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de