[PATCH] Fix bug #10831 - SIGCLD Signal handler not correctly reinstalled on old library code use - smbrun etc.
martin at meltin.net
Wed Sep 24 13:34:49 MDT 2014
On Wed, 24 Sep 2014 08:43:34 -0700, Jeremy Allison <jra at samba.org>
> On Wed, Sep 24, 2014 at 10:22:40AM +1000, Martin Schwenke wrote:
> > Today I learned about:
> > * signal handling; and
> > * functions that return function pointers (without using a typedef).
> > ;-)
> > Just out of interest, since it is only the CatchChildLeaveStatus() calls
> > that causes problems, why bother changing CatchChild()? I looked over
> > the various calls to CatchChild() and they seem OK.
> Yeah, I thought about leaving CatchChild() alone, but having
> a function that arbitrarily loses the existing handler I
> thought was a bad idea, so I cleaned up the interface
> whilst I was at it.
> Even though it's not used to return the existing
> handler currently, it really should.
Right. Sounds completely reasonable. Still:
Reviewed-by: Martin Schwenke <martin at meltin.net>
peace & happiness,
More information about the samba-technical