[PATCHES] lib/util - cleanups, build restructuring, charset compatibility

Martin Schwenke martin at meltin.net
Tue Sep 23 12:54:46 MDT 2014

On Tue, 23 Sep 2014 16:29:34 +0200, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:

> Minor nit-pick: The substitute.c and fault.c ones depend on each
> other, so the intermediate patches won't build.
> Shall we push those in this state?

Ahhh!  So, that's why they were originally in the other order...

I'm somewhat inclined to "fix" the dependency.  The issue is the use of
SMB_ASSERT() in substitute.c  I think this happens in a few places
(cyclic dependencies with SMB_ASSERT(), smb_panic()) in the utility
code. We might be better of just calling abort() and letting the abort
handler take care of it?

So, in this case, could we just drop the include of fault.h, remove
the SMB_ASSERT() and call abort() directly after logging a useful
message, like in the attached patch? I've also included the 2 patches
that would conflict as a result.  The alternative branch in my tree is

If you don't think that's a good idea then let's either push as is or
squash those 2 patches together.  Your choice...  :-)

If none of that makes sense then, sorry, it is really early here...  :-)


peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba.patches
Type: application/octet-stream
Size: 9192 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140924/9e4255a7/attachment.obj>

More information about the samba-technical mailing list