[PATCHES] lib/util - cleanups, build restructuring, charset compatibility
martin at meltin.net
Tue Sep 23 01:19:17 MDT 2014
Clean up includes for 8 files in lib/util. Then:
* Break out a subset of samba-util (above 8 files, plus 1 more) into a
new samba-util-core subsystem. Build samba-util itself and other
subsystems not needed by samba-util-core when SAMBA_UTIL_CORE_ONLY is
*not* defined. This avoids building everything else (with resulting
dependency explosion) when doing a standalone CTDB build (see
ctdb-build branch below).
* If SAMBA_UTIL_CORE_ONLY is defined then include new charset_compat.h
instead of charset/charset.h in the above (and samba_util.h). This
is a hack but, as the commit message says, I think it is the most
honest hack that avoids unnecessarily pulling in charset and then
Apart from cleanups, without SAMBA_UTIL_CORE_ONLY defined this is
intended to cause no change in a Samba build.
Please review and push if OK.
These patches are in my samba-build branch:
For context, there are 2 other branches that follow from this branch:
Changes required for a CTDB standalone build against Samba's lib/util
(subset) and tdb-wrap. We'd like to keep doing standalone builds
because it enabled easy testing.
The 1st 6 patches are currently in Amitay's autobuild so don't need
Changes required on top of ctdb-build to get CTDB into a unified
I'll post these separately once we've come to a conclusion on the
I have more patches in other branches that do more lib/util (and other)
cleanup. However, they're not needed to get to the unified build and
they need to be cleaned/split up. So I'll hold them back for a
peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 34522 bytes
Desc: not available
More information about the samba-technical