[PATCH] fix smbclient segfault
jra at samba.org
Mon Sep 22 13:20:13 MDT 2014
On Mon, Sep 22, 2014 at 10:15:10AM +0200, Andreas Schneider wrote:
> On Monday 22 September 2014 09:59:34 Michael Adam wrote:
> > Hi,
> > shouldn't subreq be freed before leaving the function,
> > i.e. further down?
> to be honest, I'm not sure. A bit further down smbXcli_req_set_pending(subreq)
> is called and I guess it needs to live longer cause of that call.
Yep, looks correct to me. smbXcli_req_set_pending(subreq) ensures
the subreq must live longer than this function.
Reviewed-by: Jeremy Allison <jra at samba.org>
More information about the samba-technical