[PATCHES] Various cleanups and minor restructuring

Martin Schwenke martin at meltin.net
Fri Sep 19 21:48:46 MDT 2014

On Fri, 19 Sep 2014 17:04:13 +0200, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:

> Pushed most of them.

> I did not push the move of mkproto. I think we should not
> depend on that for common code. I know we're not there, but
> putting mkproto into common gives a bad signal.

OK, I agree.  While I'm fixing up lib/util includes, I'll actually a
static unix_privs.h that does the right stuff... although unix_privs.h
isn't a public header.

> For the talloc_tos removal I've got a different proposal.
> See attached. If you prefer yours, you can for sure push it
> with my R-b. It is certainly a correct patch.

Pushed yours.  I had asked Amitay to double-check that talloc_tos() was
unnecessary and could be replaced by NULL, given that I thought I
understood talloc_tos(), but wasn't 100% sure I hadn't missed something
subtle.  He said, "yeah, either that or a static array of size
PATH_MAX".  I opted for the simpler patch...  but 1 less talloc() is
good.  :-)

More soon...

peace & happiness,

More information about the samba-technical mailing list