[PATCH] Just another round of random cleanups
martin at meltin.net
Thu Sep 18 01:21:07 MDT 2014
On Thu, 18 Sep 2014 07:04:33 +0200, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:
> On Thu, Sep 18, 2014 at 01:58:34PM +1000, Martin Schwenke wrote:
> > On Thu, 18 Sep 2014 13:51:18 +1000, Martin Schwenke <martin at meltin.net>
> > wrote:
> > > I think that when a library depends on a subsystem, then the library
> > > ends up including the objects for that subsystem. So, I suppose
> > > that tdb-wrap, samba-util and errors all contain samba-debug.
> > martins at rover:~/samba/samba (merge)$ nm bin/default/lib/util/libsamba-util.so | grep check_log_size
> > 000105f4 T check_log_size
> > 0001056b T force_check_log_size
> > 0001059c T need_to_check_log_size
> > martins at rover:~/samba/samba (merge)$ nm bin/default/lib/tdb_wrap/libtdb-wrap.so | grep check_log_size
> > 00002836 T check_log_size
> > 000027ad T force_check_log_size
> > 000027de T need_to_check_log_size
> > martins at rover:~/samba/samba (merge)$ nm bin/default/libcli/util/liberrors.so | grep check_log_size
> > 00019afa T check_log_size
> > 00019a71 T force_check_log_size
> > 00019aa2 T need_to_check_log_size
> > There it is! So, either there is a way around this or it isn't a
> > problem... ;-)
> They way around it might be making samba-debug a library.
> But that sounds weird to me.
Yeah, I think we're going to have to do that. Hopefully if samba-util
is a public library and samba-debug is a private library, then the
correct waf-fu will happen so that users like OpenChange won't have any
issues. However, Alexander said this one IRC:
<schwenke> ab: if one of the libraries is a public library then the
dep library needs to be public too?
<ab> schwenke: not really, at least from technical perspective --
you can have rpath hardcoded to point to private
library. I'm not sure whether waf handles that though
I guess we can try it...
peace & happiness,
More information about the samba-technical