[PATCH] Just another round of random cleanups

[Martin Schwenke]

On Thu, 18 Sep 2014 03:40:49 +0200, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:

> On Thu, Sep 18, 2014 at 09:38:25AM +1000, Martin Schwenke wrote:
> > On Wed, 17 Sep 2014 22:48:20 +0200, Volker Lendecke
> > <Volker.Lendecke at SerNet.DE> wrote:
> > 
> > > Review&push would be appreciated.
> > 
> > Nice.  Pushed to autobuild.
> > 
> > We're looking at some of the same code, so I'll post some similar
> > patches later today (will CC: you). 
> 
> Hmm. A normal make worked fine for me, [...]

Same here...

> but I see that your autobuild failed with
> 
> Waf: Leaving directory memdisk/martins/a/b750190/samba/bin'
> Build failed:
> default/source3/lib/netapi/examples/localgroup/localgroup_setinfo: Symbol check_log_size linked in multiple libraries ['tdb-wrap', 'samba-util', 'errors']
> make: *** [test] Error 1
> 
> What is this?

I just got back and started to look at it.  It is the last thing in the
top level wscript_build:

  bld.DUP_SYMBOL_CHECK()

and only seems to do anything if configure has been run with
--enable-developer.

I think that when a library depends on a subsystem, then the library
ends up including the objects for that subsystem.  So, I suppose that
tdb-wrap, samba-util and errors all contain samba-debug.

I'm hoping there's a way around this.  Fine-grained dependencies (like
samba-debug) are obviously more useful than coarse-grained - you
shouldn't always be forced to depend on samba-util.

More news as it comes to hand...

peace & happiness,
martin