[PATCH] vfs_fruit: resource fork length

Jeremy Allison jra at samba.org
Tue Sep 16 15:57:12 MDT 2014


On Tue, Sep 16, 2014 at 11:32:58AM -0700, Jeremy Allison wrote:
> On Tue, Sep 16, 2014 at 08:18:57PM +0200, Volker Lendecke wrote:
> > On Tue, Sep 16, 2014 at 10:51:09AM -0700, Jeremy Allison wrote:
> > > On Tue, Sep 16, 2014 at 10:34:05AM +0200, Ralph Böhme wrote:
> > > > Hi
> > > > 
> > > > attached please find an update for the vfs_fruit torture test and
> > > > fixes for two issue:
> > > > 
> > > > * the resource fork size that gets written to ther AppleDouble header
> > > >   is calculated wrong when the resource is extended with pwrite()
> > > > 
> > > > * the resource fork size is not updated upon ftruncate()
> > > > 
> > > > This patch series depends the other patch submitted recently.
> > > > 
> > > > Review and commit (if ok) appreciated.
> > > 
> > > LGTM - 'Reviewed-by: Jeremy Allison <jra at samba.org>'.
> > > 
> > > Can I get a second Team reviewer please ?
> > 
> > R-b: Me. Off to a talk, can you push?
> 
> Yes - done - thanks !

Ralph - trying to push this and the previous
patch I'm getting:

[573/1680 in 53m44s] samba3.vfs.fruit(s3dc)
[574/1680 in 53m45s] samba3.vfs.fruit(plugin_s4_dc)
(../source4/torture/vfs/fruit.c:1208) writing to resource fork
Open stream vfs_fruit_dir\torture_write_rfork_io:AFP_Resource:$DATA
UNEXPECTED(failure): samba3.vfs.fruit.resource fork IO(plugin_s4_dc)
REASON: _StringException: _StringException: (../source4/torture/vfs/fruit.c:1227) Incorrect status NT_STATUS_ACCESS_DENIED - should be NT_STATUS_OK

Can you investigate and let give me an
updated patchset please ?

Thanks,

	Jeremy.


More information about the samba-technical mailing list