[PATCHSET] Restructure messaging_dgm a bit

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat Sep 13 11:49:09 MDT 2014


On Thu, Sep 11, 2014 at 02:04:30PM -0700, Jeremy Allison wrote:
> On Thu, Sep 11, 2014 at 03:10:13PM +0200, Volker Lendecke wrote:
> > Hi!
> > 
> > Attached find some simplification patches to messages_dgm.c.
> > The last one does not count as simplification, but I think
> > it is the right thing to do.
> > 
> > Comments?
> 
> Next thing in my review queue... :-). More tomorrow !

One more thing: This is a little patch on top that fixes an
error path. Feel free to squash.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 5bf5a65060bcc0af70df924a7a9034d57cf2b3b3 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Sat, 13 Sep 2014 19:45:26 +0200
Subject: [PATCH] messaging_dgm: Fix an error return

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/lib/messages.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/source3/lib/messages.c b/source3/lib/messages.c
index 52d6538..57df069 100644
--- a/source3/lib/messages.c
+++ b/source3/lib/messages.c
@@ -278,6 +278,7 @@ struct messaging_context *messaging_init(TALLOC_CTX *mem_ctx,
 		if (!NT_STATUS_IS_OK(status)) {
 			DEBUG(2, ("messaging_ctdbd_init failed: %s\n",
 				  nt_errstr(status)));
+			messaging_dgm_destroy();
 			TALLOC_FREE(ctx);
 			return NULL;
 		}
-- 
1.7.9.5



More information about the samba-technical mailing list