[PATCH] namecache: fix uninitialised pointer returns
David Disseldorp
ddiss at samba.org
Fri Sep 12 05:11:00 MDT 2014
asprintf_strupper_m() doesn't set *strp on error.
Signed-off-by: David Disseldorp <ddiss at samba.org>
---
source3/libsmb/namecache.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/source3/libsmb/namecache.c b/source3/libsmb/namecache.c
index 1e61584..f325c346 100644
--- a/source3/libsmb/namecache.c
+++ b/source3/libsmb/namecache.c
@@ -37,10 +37,10 @@
* type number
*/
-static char* namecache_key(const char *name,
+static char *namecache_key(const char *name,
int name_type)
{
- char *keystr;
+ char *keystr = NULL;
asprintf_strupper_m(&keystr, NBTKEY_FMT, name, name_type);
return keystr;
@@ -239,7 +239,7 @@ static char *namecache_status_record_key(const char *name,
const struct sockaddr_storage *keyip)
{
char addr[INET6_ADDRSTRLEN];
- char *keystr;
+ char *keystr = NULL;
print_sockaddr(addr, sizeof(addr), keyip);
asprintf_strupper_m(&keystr, "NBT/%s#%02X.%02X.%s", name,
--
1.8.4.5
More information about the samba-technical
mailing list