[PATCH] vfs_acl_common: update dacl size

[Simo]

On Wed, 2014-09-10 at 11:22 -0700, Jeremy Allison wrote:
> On Tue, Sep 09, 2014 at 12:39:43PM +0200, Ralph Böhme wrote:
> > Hi
> > 
> > attached is a small fix for a missing update of dacl->size in
> > vfs_acl_common.c.
> > 
> > I'm not 100% sure if my fix is correct, but every other place munging
> > ACEs in a struct security_acl updates the size variable.
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> Can I get a second Team reviewer please ?

Reviewed-by: Simo Sorce <idra at samba.org>

Simo.

> 
> > SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> > phone: +49-551-370000-0, fax: +49-551-370000-9
> > AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> > http://www.sernet.de,mailto:kontakt@sernet.de
> 
> > >From 7353a2fa09e81d060f4c3e8d905a2a34ee603126 Mon Sep 17 00:00:00 2001
> > From: Ralph Boehme <rb at sernet.de>
> > Date: Mon, 8 Sep 2014 20:53:44 +0200
> > Subject: [PATCH] vfs_acl_common: dacl size must be updated
> > 
> > Signed-off-by: Ralph Boehme <rb at sernet.de>
> > ---
> >  source3/modules/vfs_acl_common.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
> > index 57fc6c8..b749157 100644
> > --- a/source3/modules/vfs_acl_common.c
> > +++ b/source3/modules/vfs_acl_common.c
> > @@ -343,6 +343,9 @@ static NTSTATUS add_directory_inheritable_components(vfs_handle_struct *handle,
> >  	if (psd->dacl) {
> >  		psd->dacl->aces = new_ace_list;
> >  		psd->dacl->num_aces += 3;
> > +		psd->dacl->size += new_ace_list[num_aces].size +
> > +			new_ace_list[num_aces+1].size +
> > +			new_ace_list[num_aces+2].size;
> >  	} else {
> >  		psd->dacl = make_sec_acl(psd,
> >  				NT4_ACL_REVISION,
> > -- 
> > 1.9.3
> >