smbd panic at find_oplock_types().
jra at samba.org
Tue Sep 9 18:02:44 MDT 2014
On Tue, Sep 09, 2014 at 01:12:35PM +0200, Volker Lendecke wrote:
> Remember that INTERNAL_OPEN_ONLY has the effect that this request will
> never be deferred. For me that's the main use of this flag: Not all
> callers are prepared to handle open_was_deferred. We need an indication
> to open_file_ntcreate to never defer a call. Or even better, we need to
> replace the existing deferral mechanism with a tevent_req based design,
> but that's certainly a future project.
Yes, not deferring INTERNAL_OPEN_ONLY requests is probably
the more important effect. However, I still think that
removing that flag externally to open.c and using req==NULL
to mean the same thing makes it clearer to callers (they
don't have to set two paramters that mean the same
> What about the attached patch? This fixes batch26. I haven't
> run an autobuild yet, starting that in a minute.
Let me think about it some more and take a close
On initial evalutation it looks like the right fix,
but you know how tricky this stuff is :-).
We need to commit batch26 along with this fix
anyway - can you give Hemmanth's batch26
code a 'Reviewed-by' ?
More information about the samba-technical