[PATCH 08/12] torture: Provide enough space for test EA name in raw.eas test

Kamen Mazdrashki kamenim at samba.org
Sun Sep 7 21:28:34 MDT 2014


I think you should also change following line from:
  bad_ea_name[5] = (char)i;
to
  bad_ea_name[6] = (char)i;
to preserve original idea for this test

Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>

Cheers,
kamen

On Mon, Sep 8, 2014 at 1:30 AM, <abartlet at samba.org> wrote:

> From: Andrew Bartlett <abartlet at samba.org>
>
> Found by AddressSanitizer
>
> Change-Id: I871c08200aa2591c612dfa44da92b83132f83d88
> Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> ---
>  source4/torture/raw/eas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/source4/torture/raw/eas.c b/source4/torture/raw/eas.c
> index 95a55d1..15bfb2f 100644
> --- a/source4/torture/raw/eas.c
> +++ b/source4/torture/raw/eas.c
> @@ -51,7 +51,7 @@ static bool test_eas(struct smbcli_state *cli, struct
> torture_context *tctx)
>         union smb_open io;
>         const char *fname = BASEDIR "\\ea.txt";
>         bool ret = true;
> -       char bad_ea_name[6];
> +       char bad_ea_name[7];
>         int i;
>         int fnum = -1;
>
> --
> 2.1.0
>
>


More information about the samba-technical mailing list