https://bugzilla.samba.org/show_bug.cgi?id=10766
Jeremy Allison
jra at samba.org
Thu Sep 4 05:09:20 MDT 2014
On Thu, Sep 04, 2014 at 11:41:14AM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
>
> > + if (!xconn->smb1.negprot.done) {
> > + if (type != SMBnegprot) {
> > + exit_server_cleanly("The first request has to be a negprot");
> > + }
> > + }
> >
> > instead ? Just looks cleaner (IMHO).
>
> Yes, looks good. I also moved this to the top of the function.
LGTM - pushed to master ! Thanks.
More information about the samba-technical
mailing list