s4-backupkey patches

[Andrew Bartlett]

On Thu, 2014-08-07 at 12:13 +0200, Arvid Requate wrote:
> Hello,
> 
> we received positive customer feedback on the effectiveness of my recently 
> posted patches for the backupkey protocol implementation in Samba.
> The patches are now available via
> 
> http://repo.or.cz/w/Samba/reqa.git/shortlog/refs/heads/BKRP
> 
> Feedback appreciated.

I'm very sorry for how long this has taken to get back to you.

The primary thing I see missing is the tests to prove the new behaviour
- that is, we should have a test that breaks on the old code, and works
with the new code.  

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba