[PATCH#2][2nd REVIEW?] fake data io module for samba

[Peter Somogyi]

Hi Jeremy,

Please find the next attempt of fake io module.

Missing calls: as stated later, they either do what is expected (ftrunc, 
falloc) or unsupported (aio) or not called (read/write).

Streams: not supported (documented now), I have no valid business use case 

for it.
However, increased the error to level from 1 to 10 not to get hurt (though 

I haven't met any during my tests).


Added documentation (man page).


Review appreciated.

--
Peter Somogyi
IBM Magyarországi Kft.
1117 Budapest
Infopark, Neumann János u. 1.
Hungary
Phone: +36 1 382 5469



Jeremy Allison <jra at samba.org> 
Sent by: samba-technical-bounces at lists.samba.org
10/21/2014 06:42 PM
Please respond to
Jeremy Allison <jra at samba.org>


To
Peter Somogyi/Hungary/IBM at IBMHU, 
cc
samba-technical at samba.org
Subject
Re: fake data io module for samba






On Tue, Oct 21, 2014 at 12:34:21PM +0200, Peter Somogyi wrote:
> Hi Samba team,
> 
> I've found this trivial fake io module very useful for testing samba 
> performance, therefore I suggest to put it into the main samba tree:

Code itself looks promising. However, you're catching
vfswrap_pwrite (you should probably change that to
vfs_fake_pwrite btw and also change vfswrap_pread
to vfs_fake_pread) but not catching any of the other
functions that can change the size.

For example you need to catch ftruncate_fn and
fallocate as well, plus to make it completely
generic you might need to ensure it's operating
on a non-stream handle.

Also, before I can 'Reviewed-by:' it, it needs to
have documentation as well (sorry :-).

Cheers,

                 Jeremy.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fake-data-io-module-for-performance-testing-samba.patch
Type: application/octet-stream
Size: 8976 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141030/43dce755/attachment.obj>