[PATCH] improvement to output of 10 slowest tests
obnox at samba.org
Thu Oct 30 07:03:56 MDT 2014
On 2014-10-27 at 23:40 +0100, Michael Adam wrote:
> On 2014-10-27 at 11:04 -0700, Matthieu Patou wrote:
> > On 10/27/2014 06:37 AM, Michael Adam wrote:
> > >review/push appreciated
> > >
> > >Thanks - Michael
> > >+$max = @sorted if (($max <= 0) or ($max > @sorted));
> > If max is undefined what's the expected behavior ?
> $max is never undefined in that script:
> It is initialized to 0 and set to $ARGV
> if that array element exists.
> So the worst thing that can happen is that the string
> $ARGV does not represent a (decimal) number.
> Attached find a patch that adds an error treatment
> for this case (ARGV not a decimal number).
> Also attached a patch that fixes the output of the
> slowest tests in case "--selftest-prefix" is specified
> and different from "st".
> Review/push/comment appreciated.
I pushed these with Metze's review.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: Digital signature
More information about the samba-technical