[RFC] Strategies for CTDB integration into Samba
obnox at samba.org
Thu Oct 30 03:35:45 MDT 2014
On 2014-10-30 at 14:58 +1100, Martin Schwenke wrote:
> On Wed, 29 Oct 2014 09:04:20 +0100, Michael Adam <obnox at samba.org>
> > On 2014-10-29 at 19:00 +1100, Martin Schwenke wrote:
> > > On Wed, 29 Oct 2014 08:54:06 +0100, Michael Adam <obnox at samba.org>
> > > wrote:
> > >
> > > > Question: Should we port the build changes to 4.2?
> > > > Since this is the logical consequence of shipping CTDB with
> > > > Samba, this seems reasonable.
> > >
> > > If you mean the unified build changes (and not including the latest
> > > "removal of compile against external CTDB patches") then:
> > >
> > > https://bugzilla.samba.org/show_bug.cgi?id=10892
> > >
> > > :-)
> > Ah, great!
> > I do actually meant to include also the latest patches.
> > But that could be argued into belonging into this bug's
> > patchset. :)
> I guess then you should argue away by adding a comment in bugzilla. :-)
Already did that before wrote this mail. ;-)
> I'm not sure of the process at this stage. I've opened the bug. Do I
> need to do anything or do I wait for the owner to do something?
This is how it works:
- You opened the bug.
- You can also assign it to yourself if you like, (or give
it to Amitay or me...) I think the assignee is not that
- You (or anybody) should prepare a patchset of backported
patches (ideally created with a series of "git cherry-pick -x "
commands for patches from master) and attach that patchset
to the bug.
- Ask somebody (me, amitay, ...) for review of that patchset for
4.2: This happens by going into the details of the attachmend
and adding a "review ?" entry for one ore more people (enter the
email address registered in bugzilla, e.g. obnox at samba.org).
- you could also to make it explicit directly add your review+
to the patchset.
- Wait for people to give (or deny) their review+ or review-
- If the bug carries two review+ by team members (and no review-)
then you can assign it to karolin with the request to add
the patchset to the 4.2 branch.
- If there is a review-, we need to revisit / re-discuss...
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: Digital signature
More information about the samba-technical