[PATCH 0/6] Fix spoolss EnumJobs and GetJob request handling
asn at cryptomilk.org
Thu Oct 30 01:19:28 MDT 2014
On Wednesday 29 October 2014 20:17:47 Jeremy Allison wrote:
> On Thu, Oct 30, 2014 at 01:37:45AM +0100, David Disseldorp wrote:
> > This patch set attempts to address bug 10905, which is nicely reproduced
> > by the existing rpc.spoolss.printer.addprinter.print_test_extended
> > smbtorture test.
> > Currently EnumJobs and GetJobs spoolss request handling is broken, in
> > that Samba uses and returns printer back-end allocated job (sysjob)
> > identifiers, rather than those allocated by spoolss and returned on job
> > submission.
> > I have one further patch which ensures that print_test_extended is not
> > ignored during selftest (as it now passes), but I'd like to hold off on
> > it until I can find out what is causing the flakiness in one of the
> > other spoolss tests.
> > Feedback welcome.
> LGTM - pushed.
> But correct me if I'm wrong but don't we keep fixing
> this damn bug ?
> I vaguely recall at least 3 earlier bugs getting the
> Windows jobid and the UNIX printjobid confused...
It is hard to fix bugs in this code while your eyes are bleeding :-)
Dave thanks for fixing all these spoolss job bugs!
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.org asn at cryptomilk.org
More information about the samba-technical