[PATCH 0/6] Fix spoolss EnumJobs and GetJob request handling
David Disseldorp
ddiss at samba.org
Wed Oct 29 18:37:45 MDT 2014
This patch set attempts to address bug 10905, which is nicely reproduced
by the existing rpc.spoolss.printer.addprinter.print_test_extended
smbtorture test.
Currently EnumJobs and GetJobs spoolss request handling is broken, in
that Samba uses and returns printer back-end allocated job (sysjob)
identifiers, rather than those allocated by spoolss and returned on job
submission.
I have one further patch which ensures that print_test_extended is not
ignored during selftest (as it now passes), but I'd like to hold off on
it until I can find out what is causing the flakiness in one of the
other spoolss tests.
Feedback welcome.
Cheers, David
--
source3/include/printing.h | 1 +
source3/printing/printing.c | 70 +++++++++++++++++++++++++++++++-----------
source3/rpc_server/spoolss/srv_spoolss_nt.c | 212 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------
3 files changed, 190 insertions(+), 93 deletions(-)
More information about the samba-technical
mailing list