[PATCH] torture/spoolss: cleanup print_job_enum test jobs

David Disseldorp ddiss at suse.de
Wed Oct 29 10:31:08 MDT 2014

On Wed, 29 Oct 2014 17:03:34 +0100, Stefan (metze) Metzmacher wrote:

> Am 29.10.2014 um 11:54 schrieb David Disseldorp:
> > Purge print queue on startup to ensure that the test is not affected by
> > jobs queued for prior tests. Also, empty the queue at the end of the
> > test to play nice with others.
> > 
> > Signed-off-by: David Disseldorp <ddiss at samba.org>  
> Reviewed-by: me

Thanks Metze, Andreas has pushed this one through.
Unfortunately I'm now seeing another flakey failure in autobuild
that I can't reproduce locally:

Testing EnumJobs level 2
WARNING!: ../source4/torture/rpc/spoolss.c:3293: r.out.result was WERR_INSUFFICIENT_BUFFER, expected WERR_OK: EnumJobs failed
UNEXPECTED(failure): samba3.rpc.spoolss.printer.addprinter.print_job_enum(s3dc)
REASON: _StringException: _StringException: ../source4/torture/rpc/spoolss.c:8911: Expression `test_EnumJobs_args(tctx, b, &t->handle, 2, ((WERROR) { 0x00000000 }), &count, &info)' failed: EnumJobs with valid level

The WERR_INSUFFICIENT_BUFFER error should have already been caught and
handled by the at spoolss.c:3284. One theory would be that the first
enum request is handled before all jobs are submitted to the printing
back-end, or that something else is fiddling with the queue at the time.
I'll need to look at this a bit further, sorry.

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141029/0387447f/attachment.pgp>

More information about the samba-technical mailing list