[PATCH] fix various build problems

Michael Adam obnox at samba.org
Tue Oct 28 13:58:14 MDT 2014

On 2014-10-28 at 12:45 -0700, Jeremy Allison wrote:
> On Tue, Oct 28, 2014 at 08:35:05PM +0100, Jelmer Vernooij wrote:
> > On Tue, Oct 28, 2014 at 06:28:19PM +0100, Michael Adam wrote:
> > > Attached is a patch to fix this problem.
> > > It does so by filtering out the standard directories.
> > > It uses ${CC} -print-search-dirs to build
> > > the list of standard lib dirs. At least gcc and clang
> > > support this.
> > Thanks for working on this!
> > 
> > > The patch may need some more changes, because it
> > > currently touches wafadmin to filter the standard paths.
> > We should really avoid changing wafadmin. Any changes would be lost when
> > we next pull in a new version of waf.
> If we can, we should. But if we've sent a
> patch upstream I don't think it's an unforgivable
> sin to change our downstream version whilst
> waiting for an upstream patched version.

Right. 64f5e24100a764ec198cab9a8d2c43fa86e7027c is a good
example where this has worked out. If it is a genuine
upstream bug, we should touch upstream.

But that being said, the patch is still inconsistent
in that it fills the standard libpaths in wafsamba but
does the filtering based on that in wafadmin. I mentioned
that explicitly in the mail and commit msg. The patch is
more a proposal for working on a final patch....

I still need to find the place to do the proper filtering
in wafsamba - this will be somewhat more involved, since
we need to parse the flags for -L$PATH ... but doable.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141028/470d8b77/attachment.pgp>

More information about the samba-technical mailing list