[PATCH] Two messaging fixes

Jeremy Allison jra at samba.org
Fri Oct 24 09:36:09 MDT 2014


On Fri, Oct 24, 2014 at 06:59:33AM +0200, Volker Lendecke wrote:
> On Thu, Oct 23, 2014 at 02:56:39PM -0700, Jeremy Allison wrote:
> > On Thu, Oct 23, 2014 at 04:34:46PM +0200, Volker Lendecke wrote:
> > > Hi!
> > > 
> > > Hopefully the comments are descriptive enough. Proper
> > > rundown of structures is hard...
> > 
> > Ouch. That first patch hurt my brain :-). But after
> > staring at it for long enough it looks right... I
> > think ! :-).
> 
> Yes, it took me a while to understand the valgrind traces as well. But it
> does fix a reliable crash that happens when you do a messaging_read_send
> in the parent and the child then does a reinit_after_fork and then
> receives a message.
> 
> It is not a problem with 4.2, as messaging_read_send is not used this way.

Yeah I checked that :-).

> Thanks for pushing it!

No problem, thanks for fixing it :-).


More information about the samba-technical mailing list