[PATCH] Remove ctdb feature checks from configure
obnox at samba.org
Fri Oct 24 05:07:01 MDT 2014
On 2014-10-24 at 12:40 +0200, Volker Lendecke wrote:
> On Fri, Oct 24, 2014 at 12:33:18PM +0200, Michael Adam wrote:
> > The fact that autobuild is our own tool that we adapt to our
> > needs should not be new to either of you. ;-)
> That's not quite true. The list of build environments is pretty much a
> promise that we've given to the world to work.
Er, I'd rather say this is the things that _we_ want built
and tested before allowing a patch to master.
And nobody proposes to drop the samba-ctdb autobuild target.
Just we now have a different means of building samba with
cluster support than we had before. If it makes life easier,
then we should adapt it.
We can of course still discuss whether we want to
keep the ability to build samba against an external ctdb.
> > And after all, ctdb is still built, just as a aprt of
> > samba, and samba is still built against ctdb, so I can't
> > imagine which build problems you have been fighting with
> > that I have now talked into nonexistence. :-D
> As a simple example try including "server_id.h" somewhere. There's a
> reason why ctdb/client/ctdb_client.c has to duplicate the definition
> of struct server_id.
And what is the reason?
> This is not really possible to get right unless we
> make the standalone ctdb build also include the pidl generated stuff. And
> this is just beyond what I am able to do with waf. So this makes it very
> hard to advance the messaging. I will get there eventually, but it just
> takes a lot of time.
So, if I get you right, all your problems vanish if we drop
not only the possibility for samba to build against an external
ctdb, but also the possiblity to build ctdb separately, and only
allow for building ctdb along with samba. So why are you not happy
about that proposal then, if it makes live so much easier? :-)
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: Digital signature
More information about the samba-technical