[PATCH] Remove ctdb feature checks from configure
obnox at samba.org
Fri Oct 24 03:02:19 MDT 2014
On 2014-10-24 at 10:51 +0200, Volker Lendecke wrote:
> On Fri, Oct 24, 2014 at 01:30:56PM +1100, Amitay Isaacs wrote:
> > This is a re-post since no one commented on these patches.
> > These patches remove the configure checks for ctdb features as we now have
> > the ctdb building with file server code.
> Do we really want this? One checkin says that we always
> build with integrated ctdb. Our autobuild system requires
> that we still support the ctdb standalone as well as the
> samba build with external ctdb, so I think we can't drop
> these checks.
Well... that autobuild stuff was from the times before we had
a combined build. Implying that this requires keep Samba able
to build against external ctdb forever is not correct. After
all, autobuild is our script and it can be changed. And it
_should_ be changed if we go down the path Amitay proposes.
So you could turn your argument into stating that Amitay's patch
is simply not complete in that it forgot to change autobuild. :-)
All that being said, I am also a bit hesitant, but thinking
about it, it is really only consequent and consistent.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: Digital signature
More information about the samba-technical