[PATCHES] selftest related

[Matthieu Patou]

On 10/17/2014 02:26 AM, Michael Adam wrote:
> Hi,
>
> I just applied and tested these patches, and there is an issue:
>
> If e.g. do
>
> $ buildnice make test TESTS=messaging
>
> then I get:
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [0/8 in 0s] samba.tests.messaging
> [1/8 in 0s] samba3.smbtorture_s3.LOCAL-MESSAGING-READ1
> [2/8 in 0s] samba3.smbtorture_s3.LOCAL-MESSAGING-READ2
> [3/8 in 0s] samba3.smbtorture_s3.LOCAL-MESSAGING-READ3
> [4/8 in 0s] samba3.smbtorture_s3.LOCAL-MESSAGING-READ4
> [5/8 in 0s] samba3.smbtorture_s3.LOCAL-MESSAGING-FDPASS1
> [6/8 in 0s] samba3.smbtorture_s3.LOCAL-MESSAGING-FDPASS2
> [7/8 in 0s] samba4.local.messaging
>
> ALL OK (7 tests in 8 testsuites)
>
> A summary with detailed information can be found in:
>    ./st/summary
> TOP 10 slowest tests
> Traceback (most recent call last):
>    File "./buildtools/bin/waf", line 76, in <module>
>      Scripting.prepare(t, cwd, VERSION, wafdir)
>    File "/data/obnox/devel/samba/master-push.git/buildtools/wafadmin/Scripting.py", line 145, in prepare
>      prepare_impl(t, cwd, ver, wafdir)
>    File "/data/obnox/devel/samba/master-push.git/buildtools/wafadmin/Scripting.py", line 135, in prepare_impl
>      main()
>    File "/data/obnox/devel/samba/master-push.git/wscript", line 347, in main
>      wildcard_main(wildcard_cmd)
>    File "./buildtools/wafsamba/samba_wildcard.py", line 110, in wildcard_main
>      fun(ctx)
>    File "/data/obnox/devel/samba/master-push.git/selftest/wscript", line 241, in cmd_testonly
>      cmd = "./script/show_testsuite_time %s/subunit %d" % (Options.options.selftest_prefix, nb)
> AttributeError: Values instance has no attribute 'selftest_prefix'
> make: *** [test] Error 1
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Therefore I fixed the patch "selftest: report the 10 slowest tests..."
> to read  Options.options.SELFTEST_PREFIX instead of
> Options.options.selftest_prefix.
>
> One other point is this:
> I am not convinced of the patch that changed the test number reported.
> I always understood the output [X/Y in Zs] as
> "now starting test X out of Y after Z seconds of test run".
> because it is prepended to the test started just now.
> When tests are executed sequentially, your patch to report
> "I have run X tests out of Y in Z seconds" makes some sense,
> but I find it confusing still.
>
> I would propose to remove the "in" from "in Zs" and e.g. instead
> say "at Zs" (or "after Zs"m but that seems to long).

I like it, so feel free to push your patch with my review.

Matthieu

-- 
Matthieu Patou
Samba Team
http://samba.org