[PATCH] lib/util: Add optional format argument to timeval_str_buf()

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Oct 10 04:14:14 MDT 2014

On Fri, Oct 10, 2014 at 07:20:03PM +1100, Martin Schwenke wrote:
> Is this better?  :-)

Much better, thanks!

Technically it's missing a bounds check for dst->buf + len
in the last snprintf. Probably that belongs into that
if(rfc3339){ clause. This will never kick in, but it
looks fishy and I'd like to have it the same as the
if-statement before


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list