[PATCH] lib/util: Add optional format argument to timeval_str_buf()

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Oct 8 23:59:43 MDT 2014

On Thu, Oct 09, 2014 at 04:36:17PM +1100, Martin Schwenke wrote:
> A simple patch to allow the format for most of the timeval_str_buf()
> output to be optionally specified.  NULL means use the current default.
> Please review and push if OK.

Hmm. Right now the timeval_str_buf function can be assumed to never fail,
because timeval_buf is large enough. If we now add a format argument,
it could easily overflow unnoticed. Is that what we want?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list