[PATCH] Finish work to enforce smb signing in winbindd
abartlet at samba.org
Wed Oct 8 12:57:06 MDT 2014
On Wed, 2014-10-08 at 16:32 +0200, Stefan (metze) Metzmacher wrote:
> Am 08.10.2014 um 09:27 schrieb Andrew Bartlett:
> > On Wed, 2014-10-01 at 23:47 +0200, Stefan (metze) Metzmacher wrote:
> >> Hi Andrew,
> >>> I've tried to look into the failure with your autobuild, but cannot
> >>> reproduce locally. But this patch might help at least give us more
> >>> info.
> >> Yes, 2 private autobuilds also fail.
> >> while a local TDB_NO_FSYNC=1 buildnice make -j test
> >> TESTS=samba.blackbox.wbinfo FAIL_IMMEDIATELY=1 SOCKET_WRAPPER_KEEP_PCAP=1
> >> gives unexpected success...
> > One of the challenges is that this test depends on the previous test
> > calling wbinfo --change-secret. However, running both doesn't seem to
> > be enough to trigger it.
> > Anyway, the attached is enough to fix the branch.
> > I've integrated it with the other patches, and have a new WIP branch
> > (all the patches) at:
> > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/subdomain-wip4
> > I have the patches for master here:
> > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/subdomain-for-master6
> > The subdomain-wip4 just passed a private autobuild, and the
> > subdomain-for-master6 branch I'll do a private autobuild on now, but I
> > expect it to pass as it only strips off unrelated patches.
> > Please review/push the branch (not the attached fixup demonstration ;-)
> I'll look at the branches tomorrow, but the patch seems to introduce
> a memory leak.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical