[PATCHES] lib/util - cleanups, build restructuring, charset compatibility

Jeremy Allison jra at samba.org
Fri Oct 3 12:28:11 MDT 2014


On Fri, Oct 03, 2014 at 04:39:26PM +1000, Martin Schwenke wrote:
> On Fri, 26 Sep 2014 15:45:05 +1000, Martin Schwenke <martin at meltin.net>
> wrote:
> 
> > On Wed, 24 Sep 2014 04:54:46 +1000, Martin Schwenke <martin at meltin.net>
> > wrote:
> > 
> > > So, in this case, could we just drop the include of fault.h, remove
> > > the SMB_ASSERT() and call abort() directly after logging a useful
> > > message, like in the attached patch? I've also included the 2 patches
> > > that would conflict as a result.  The alternative branch in my tree is
> > > samba-build-alt.
> > 
> > I've looked at various alternatives and decided that this is the best
> > option.  I've re-pushed my samba-build branch with this improvement.
> 
> Reposting latest patchset.  I've rebased my samba-build branch and
> pushed it again...
> 
> I'm a little backed up behind this patchset (and the next one which
> will allow CTDB to use modern samba-util and samba-debug).  :-(
> 
> Thanks for any feedback...  :-)

Looks like a really nice cleanup job ! Let me spend
some more time looking it over then I'll push if I'm
happy.

Cheers,

	Jeremy.


More information about the samba-technical mailing list