[PATCH] Some patches around profiling
realrichardsharpe at gmail.com
Thu Oct 2 14:30:21 MDT 2014
On Thu, Oct 2, 2014 at 12:38 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Thu, Oct 02, 2014 at 08:31:27AM -0700, Richard Sharpe wrote:
>> While I don't have strong feelings about this, it does seem that it
>> complicates the lives of people who are learning their way around the
>> code. This means they need to read the wscript to understand what is
>> going on.
> Maybe we should better comment it?
I think a comment at the start of the file would be a good solution.
That allows us to clean stuff up and allows newbies to know what is
going on. I would be happy with that.
> Or maybe develop naming
> conventions for the file names? I've started this quite a
> while ago with source3/lib/pthreadpool/. There we have a
> sync dummy implementation for systems where pthreads should
> not be used.
> Nevertheless, attached find a corrected patchset. I started
> the git format-patch at the wrong hash and thus missed two
> Sorry for that,
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical