[PATCHES] make delaywrite torture tests more reliable (part 1)

Andrew Bartlett abartlet at samba.org
Thu Oct 2 12:34:24 MDT 2014

On Thu, 2014-10-02 at 17:31 +0200, Michael Adam wrote:
> Attached find a first patchset to make our delaywrite
> torture tests more reliable.
> This patchset treats the first group of tests
> that essentially check whether the write time
> is immediately updated by the server after a
> truncation/expansion operation.
> There was a potentially false failure condition
> in these tests, where a long running fileinfo
> call would let torture think the server did
> not update the time immediately. This was a
> frequent cause of failure in autobuild.
> It should be gone now.
> The patches treat each of the functions separately,
> also doing some additional cleanup work.
> Review/Comment/push appreciated!

I've reviewed these, and pushed them to autobuild, except for the 3 you
mention above, because I need to be convinced as to the correctness.

Isn't the issue that we want to know not only that the write time is
updated to the correct value, but that it is updated essentially
immediately, not some time later?

I also removed an extra printf argument in 3 of the torture_comment
calls, that caused the compile to break on my system.


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list