[PATCH] Create talloc-less functions for formating GUID

Matthieu Patou mat at samba.org
Wed Oct 1 00:42:07 MDT 2014

Actually I recall why I haven't changed GUID_string myself:

There is cases where the caller of GUID_string expect the string to be
talloced for instance in dns_generate_keyname in lib/addns/dnsutils.c

It's not the majority but still it's good minority so this needs to be
taken into account.

On Mon, Sep 29, 2014 at 11:59:11PM -0700, Matthieu Patou wrote:
> On 09/29/2014 11:34 PM, Volker Lendecke wrote:
> >On Mon, Sep 29, 2014 at 05:57:11PM -0700, Matthieu Patou wrote:
> >>I would like to discuss this patch, if I understand well it's in the
> >>same idea as what Volker did for file_id to strings function.
> >>
> >>Is ok or do we need something else ?
> >Well, I like it, except for some different formatting. See
> >attached. Also, we should use it right away in GUID_string.
> >Also see attached. If you want to push it, Reviewed-by: Me.
> >
> >Volker
> >
> I like your idea too.
> I'll wait for a few hours to get more feedback and if nothing bad
> push both patches.
> Thanks for the review.
> Matthieu.
> -- 
> Matthieu Patou
> Samba Team
> http://samba.org

More information about the samba-technical mailing list