[PATCH] Fixing Bug 10720 - error: Unable to convert first SID

[Garming Sam]

On 26/11/14 16:11, Garming Sam wrote:
> The first two patches improves our current testing to correctly 
> identify the error. They simply build upon the existing wbinfo_sid2xid 
> tests and are currently in auto-build.
>
> The other three patches fix the actual issue. The first plumbs a 
> pointer to struct unixid instead of uid/gid. The second fixes the 
> return of the id type and the last fixes the ABI - which with 
> renaming, we can also fix another bug 
> (https://bugzilla.samba.org/show_bug.cgi?id=10355) where it has naming 
> conflicts with Brookhaven Protein DataBank libpdb.
>

The first two patches are now in master, with a minor change to flush 
the cache for the other tests.

The other three only appear to have failed the duplicate symbol check so 
I've reattached the patches with the build scripts slightly modified so 
they don't depend on pdb directly.


Thoughts would be nice.


Thanks,

Garming Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-idmap-unify-passdb-id_to_sid-methods.patch
Type: text/x-patch
Size: 17187 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141128/0466d669/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-idmap-return-the-correct-id-type-to-id_to_sid-method.patch
Type: text/x-patch
Size: 2745 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141128/0466d669/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-pdb-Increase-version-number-to-fix-ABI.patch
Type: text/x-patch
Size: 25213 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141128/0466d669/attachment-0002.bin>