Patch: Change create blob tags to be blobs as well to handle stuff done by HyperV over SMB
realrichardsharpe at gmail.com
Thu Nov 27 11:33:52 MST 2014
On Mon, Nov 24, 2014 at 10:36 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Sat, Nov 08, 2014 at 04:05:09PM -0800, Richard Sharpe wrote:
>> Hi folks,
>> This builds against the latest master branch (as of today).
>> However, some of the names I am not happy with some of the names and would
>> appreciate any feedback.
>> Richard Sharpe
>> From f163802775b0b7ad2b669262bc2d983b0356be39 Mon Sep 17 00:00:00 2001
>> From: Richard Sharpe <realrichardsharpe at gmail.com>
>> Date: Sat, 8 Nov 2014 16:00:57 -0800
>> Subject: [PATCH] Convert the tags in create blobs into blobs so we can handle
>> create blobs that are not strings, as in the ones I found used by HyperV over
> Reviewed-by: Volker Lendecke <vl at samba.org>
> However, I think that smb2_create_recv could benefit from a
> static int data_blob_cmp_str(const DATA_BLOB *blob, const char *str)
> DATA_BLOB strblob = data_blob_const(str, strlen(str));
> return data_blob_cmp(blob, &strblob);
> to make it stylistically a bit nicer. What do you think?
Sounds good to me. I will rework it after I look at Stefan's comments.
More information about the samba-technical