[PATCH 0/4] Build fixes

Andrew Bartlett abartlet at samba.org
Wed Nov 26 02:13:53 MST 2014


On Thu, 2014-11-20 at 10:26 +0100, Andreas Schneider wrote:
> Here are some patches which fix build errors on my system and correctly
> enables some libraries only in the AD DC build.
> 
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/master-waf
> 
> Andreas Schneider (4):
>   dfs_server: Only build in case we build an AD DC too.
>   dns_server: Only build common library if AD DC is enabled.

These two are in autobuild

>   ldb-samba: Only build extensions and ildap if we build the AD DC.

I don't see why these are connected to being an AD DC.  They are also
valuable client functions. 

>   ntdb: Fix control reaches end of non-void function.

I'll leave this to others to comment on.  It ends up being a war of the
compilers given another compiler could recognise the NORETURN attribute
and complain about unreachable code...

>  dfs_server/wscript_build             | 4 ++--
>  lib/ldb-samba/wscript_build          | 6 ++++--
>  lib/ntdb/test/run-01-new_database.c  | 6 ++++++
>  lib/ntdb/test/run-02-expand.c        | 6 ++++++
>  lib/ntdb/test/run-05-readonly-open.c | 6 ++++++
>  lib/ntdb/test/run-10-simple-store.c  | 6 ++++++
>  lib/ntdb/test/run-11-simple-fetch.c  | 6 ++++++
>  lib/ntdb/test/run-12-check.c         | 6 ++++++
>  lib/ntdb/test/run-35-convert.c       | 6 ++++++
>  lib/ntdb/test/run-capabilities.c     | 6 ++++++
>  source4/dns_server/wscript_build     | 2 +-
>  11 files changed, 55 insertions(+), 5 deletions(-)

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list