[PATCH] smbclient -L //dns.domain.name fails

[Jeremy Allison]

On Mon, Nov 24, 2014 at 04:26:12PM +0100, Andreas Schneider wrote:
> Hi,
> 
> doing 'smbclient -L //win2008.dns.domain.name' fails in Samba 4.x. It
> worked before in Samba 3.6 returning success.
> 
> asn at samba:~/workspace/projects/samba/git> bin/smbclient -L discworlddomain.discworld.site -Ujoe1%secret; echo "RETURN VALUE: $?"
> Domain=[DISCWORLD] OS=[Windows Server 2008 R2 Enterprise 7601 Service Pack 1] Server=[Windows Server 2008 R2 Enterprise 6.1]
> 
>         Sharename       Type      Comment
>         ---------       ----      -------
>         ADMIN$          Disk      Remote Admin
>         C$              Disk      Default share
>         IPC$            IPC       Remote IPC
>         NETLOGON        Disk      Logon server share 
>         public          Disk      
>         SYSVOL          Disk      Logon server share 
>         test            Disk      
> Connection to discworlddomain.discworld.site failed (Error NT_STATUS_RESOURCE_NAME_NOT_FOUND)
> NetBIOS over TCP disabled -- no workgroup available
> RETURN VALUE: 1
> 
> As you can see above the shares are correclty listed but the return value of
> the executable indicates a failure. The following patches return 0 instead.
> 
> Cheers,

LGTM. Pushed - thanks !