[PATCH] Fix 2 clang warnings

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Nov 24 08:14:51 MST 2014

On Mon, Nov 24, 2014 at 10:08:47AM -0500, Ira Cooper wrote:
> -                            tmpel = tmpel;
>                          }
>                          tmpel->values[tmpel->num_values -1].data
> =talloc_steal(tmpel->values, el->values[k].data);
>                          tmpel->values[tmpel->num_values -1].length =
> el->values[k].length;
> --
> 1.9.1
> I'm a bit concerned about this one. Matthieu, can you shed some light on
> this line?  (I think the git blame pointed the finger at you...)
> It really looks like it could be a compiler bug workaround or something
> bizarre like that that?
> Otherwise, it's clearly "right".  But lines like that.... scare me a bit.

Yes, same feeling here. But this is old, and the bug might
be gone. If we need it, we should clearly mark it with a


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list