[PATCH] SMB2 AAPL create context (was: Mac OS Mavericks über slow)

[Ralph Böhme]

On Mon, Nov 10, 2014 at 08:19:05AM +0100, Ralph Böhme wrote:
> On Fri, Nov 07, 2014 at 04:10:12PM -0800, Jeremy Allison wrote:
> > On Sat, Nov 01, 2014 at 08:43:14AM +0100, Ralph Böhme wrote:
> > > Hi Jeremy,
> > > 
> > > On Fri, Oct 31, 2014 at 01:58:38PM -0700, Jeremy Allison wrote:
> > > > Ralph, can you re-post the AAPL create context
> > > > patch with your latest changes ?
> > > > 
> > > > I'd love to get this reviewed and into the
> > > > code base now you're a Team member :-).
> > > 
> > > that would be great!
> > > 
> > > Patchset attached, couldn't rebase on master as sn is still down.
> > 
> > > diff --git a/source3/smbd/globals.h b/source3/smbd/globals.h
> > > index d0015d5..5137e5e 100644
> > > --- a/source3/smbd/globals.h
> > > +++ b/source3/smbd/globals.h
> > > @@ -504,6 +504,9 @@ struct smbXsrv_connection {
> > >  			uint32_t max_trans;
> > >  			uint32_t max_read;
> > >  			uint32_t max_write;
> > > +			bool use_aapl_crtctx;
> > > +			bool smb2_crtctx_aapl_readdir_attr;
> > > +			bool smb2_crtctx_aapl_unix_info;
> > >  		} server;
> > >  
> > >  		struct smbd_smb2_request *requests;
> > 
> > OK, adding these into the struct smbXsrv_connection is
> > *so* the wrong place to put these :-).
> 
> :)
> 
> > 
> > I'm not sure what the right place is yet, but I don't
> > think it's there... :-).
> 
> I'd highly appreciate a recommendation where to hang them off, in the
> meantime I'll poke around some more looking for the right place.

smbXsrv_connection also has smb1.unix_info.client_cap_low which is
used similiarily in trans2.c with a bunch of feature flags.

I've looked arond some more, but couldn't come up with any other place
to hang the AAPL flags off.

Cheerio!
-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de