profiling patches (Re: Remove NMBD related profiling)
jra at samba.org
Wed Nov 19 10:14:08 MST 2014
On Mon, Nov 17, 2014 at 08:28:56PM +0100, Stefan (metze) Metzmacher wrote:
> Am 31.10.2014 um 17:29 schrieb Jeremy Allison:
> > On Fri, Oct 31, 2014 at 08:38:48AM +0100, Stefan (metze) Metzmacher wrote:
> >> Hi,
> >> I just noticed that nmbd never calls profile_setup(),
> >> which means that profiling is always disabled and there's
> >> no way to activate it, also smbcontrol can't activate it.
> >> Would it be ok if I remove nmbd profiling completely?
> >> Comments please:-)
> > +1 from me. The less code in nmbd the better.
> Here're the patches and some more cleanups and improvements.
> There's more to come, converting the sysv share memory into
> a profiles.tdb and detailed profiling per user+share (at least
> for SMB2).
> Please review and push.
LGTM. Pushed - thanks !
More information about the samba-technical