Latest leases patchset - getting there !

Jeremy Allison jra at
Tue Nov 18 12:10:55 MST 2014

On Mon, Nov 17, 2014 at 08:02:38PM +0100, Stefan (metze) Metzmacher wrote:
> It would also be good to verify this section with a test:
>         if (lp_locking(fsp->conn->params) && file_has_brlocks(fsp)) {
>                 DEBUG(10,("grant_fsp_oplock_type: file %s has byte range
> locks\n",
>                         fsp_str_dbg(fsp)));
>                 granted &= ~SMB2_LEASE_READ;
>         }
> We need to make sure we never grant "W" or WH" leases.
> It's also unclear to me why a client shouldn't be able to get a read lease,
> when it already has brlocks (and a possible write lease).

Yes, this is wrong. I now have a simple leases+brlock
test showing Windows doesn't break RH leases when brlocks
are added.

More information about the samba-technical mailing list