Latest leases patchset - getting there !

Jeremy Allison jra at
Mon Nov 17 09:26:59 MST 2014

On Mon, Nov 17, 2014 at 04:42:38PM +0100, Stefan (metze) Metzmacher wrote:
> I'm not sure I can follow you here...
> If the sharemode is an oplock, we can only break to level2 or none,
> so we need to remove both.
> But the order of my checks was wrong, this should only
> happen when we have to break anyway.
> The attached patches on top of everything else passes
> autobuild for me.

Fair enough. I'll go through this today.

The logic here is... complex to say the least :-).

> I added also a few more tests, which demonstrate that
> a open with overwrite=true, also break a lease down to none,
> but only if the lease if not in 'breaking' mode already.
> (breaking2, while I renamed the old breaking2 to breaking3).
> The 2nd test breaking4 demonstrates that we should not
> delay a overwrite opener, if there's only a "RH" lease.

Great ! I'll write the test for the dynamic share
path today, and then I think we have full coverage
(fingers crossed :-).


More information about the samba-technical mailing list